From: Gerd Hoffmann <kraxel@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH V10 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c
Date: Mon, 04 Jan 2010 15:52:46 +0100 [thread overview]
Message-ID: <4B4200BE.9090405@redhat.com> (raw)
In-Reply-To: <1261642160-22754-2-git-send-email-yamahata@valinux.co.jp>
> +void pc_smbus_init(PCSMBus *smb)
> +{
> + smb->smbus = i2c_init_bus(NULL, "i2c");
> +}
This function should take a additional "DeviceState *parent" argument
and pass it down to i2c_init_bus() instead of NULL. Patch #21
(acpi_piix4: qdevfy) should pass the piix4-pm DeviceState to
pc_smbus_init(). Then the smbus and all connected devices should be
correctly hooked up in the device tree and visible in 'info qtree'.
cheers,
Gerd
next parent reply other threads:[~2010-01-04 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1261642160-22754-1-git-send-email-yamahata@valinux.co.jp>
[not found] ` <1261642160-22754-2-git-send-email-yamahata@valinux.co.jp>
2010-01-04 14:52 ` Gerd Hoffmann [this message]
[not found] ` <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp>
2010-01-04 14:56 ` [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback Gerd Hoffmann
2010-01-05 5:34 ` Isaku Yamahata
2010-01-04 14:59 ` [Qemu-devel] Re: [PATCH V10 00/27] split out piix specific part from pc emulator and some clean ups Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4200BE.9090405@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).