From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NRoIn-0004ts-1j
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:53:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NRoIi-0004rY-Fb
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:53:00 -0500
Received: from [199.232.76.173] (port=35097 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NRoIi-0004rQ-8s
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:52:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1025)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NRoIh-0001OA-Pl
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:52:56 -0500
Message-ID: <4B4200BE.9090405@redhat.com>
Date: Mon, 04 Jan 2010 15:52:46 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1261642160-22754-1-git-send-email-yamahata@valinux.co.jp>
	<1261642160-22754-2-git-send-email-yamahata@valinux.co.jp>
In-Reply-To: <1261642160-22754-2-git-send-email-yamahata@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH V10 01/27] acpi: split out pc smbus
 routines from acpi.c into pc_smbus.c
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

> +void pc_smbus_init(PCSMBus *smb)
> +{
> +    smb->smbus = i2c_init_bus(NULL, "i2c");
> +}

This function should take a additional "DeviceState *parent" argument 
and pass it down to i2c_init_bus() instead of NULL.  Patch #21 
(acpi_piix4: qdevfy) should pass the piix4-pm DeviceState to 
pc_smbus_init().  Then the smbus and all connected devices should be 
correctly hooked up in the device tree and visible in 'info qtree'.

cheers,
   Gerd