From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRoMf-0006OY-7C for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:57:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRoMa-0006NI-3G for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:57:00 -0500 Received: from [199.232.76.173] (port=56466 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRoMZ-0006NF-Vn for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:56:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55659) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NRoMZ-0002qp-FD for qemu-devel@nongnu.org; Mon, 04 Jan 2010 09:56:55 -0500 Message-ID: <4B4201B2.2070201@redhat.com> Date: Mon, 04 Jan 2010 15:56:50 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1261642160-22754-1-git-send-email-yamahata@valinux.co.jp> <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp> In-Reply-To: <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On 12/24/09 09:09, Isaku Yamahata wrote: > The argument will be used later to remove global variable. > -static int piix4_device_hotplug(PCIDevice *dev, int state); > +static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state); You are using that to pass the piix4-pm device state. How about using "DeviceState*" instead of "void*" then? cheers, Gerd