From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NRpTb-0006gT-B4
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 11:08:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NRpTW-0006fs-QX
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 11:08:14 -0500
Received: from [199.232.76.173] (port=48774 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NRpTW-0006fp-KE
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 11:08:10 -0500
Received: from mx20.gnu.org ([199.232.41.8]:48390)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1NRpTV-0002a1-HJ
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 11:08:10 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NRpTM-0000K8-6o
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 11:08:00 -0500
Message-ID: <4B421258.8030803@redhat.com>
Date: Mon, 04 Jan 2010 17:07:52 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-console: Add a virtio-serial
	bus, support for multiple devices and ports
References: <1261504146-26018-1-git-send-email-amit.shah@redhat.com>	<1261504146-26018-2-git-send-email-amit.shah@redhat.com>	<1261504146-26018-3-git-send-email-amit.shah@redhat.com>	<m33a31lrrk.fsf@crossbow.pond.sub.org>	<20091223150732.GA15932@amit-x200.redhat.com>	<m3aax9ikec.fsf@crossbow.pond.sub.org>	<20091223194020.GA22864@amit-x200.redhat.com>	<m3fx71fioz.fsf@crossbow.pond.sub.org>	<20091224051415.GA25261@amit-x200.redhat.com>
	<m38wcsdbhf.fsf@crossbow.pond.sub.org>
In-Reply-To: <m38wcsdbhf.fsf@crossbow.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org, agraf@suse.de

On 12/24/09 09:26, Markus Armbruster wrote:
> We could declare that -virtioconsole always creates a bus a feature, but
> I can do that in good conscience only if the console created along with
> it always gets attached to it, even when other suitable buses exist.

I'd just discourage mixing -virtioconsole and -device virtio-serial-$bus

The whole point of -virtioconsole is backward compatibility for 
management apps / start scripts and the like and it should create a 
device which can be used by the guest like the qemu 0.11 virtioconsole.

If you are using device virtio-serial-$bus you are obviously not needing 
the backward compatibility stuff ;)

cheers,
   Gerd