Re: [Qemu-devel] [PATCH V4 04/18] support NEC PC-9821 architecture

[Anthony Liguori <anthony@codemonkey.ws>]

On 12/22/2009 11:40 AM, TAKEDA, toshiya wrote:
> Signed-off-by: TAKEDA, toshiya<t-takeda@m1.interq.or.jp>
> ---
>   hw/pc98.c |  317 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/pc98.h |   65 +++++++++++++
>   2 files changed, 382 insertions(+), 0 deletions(-)
>   create mode 100644 hw/pc98.c
>   create mode 100644 hw/pc98.h
>
> diff --git a/hw/pc98.c b/hw/pc98.c
> new file mode 100644
> index 0000000..4bc4805
> --- /dev/null
> +++ b/hw/pc98.c
> @@ -0,0 +1,317 @@
> +/*
> + * QEMU NEC PC-9821 System Emulator
> + *
> + * Copyright (c) 2009 TAKEDA, toshiya
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */

I don't think we are really that far from being able to create an NEC 
PC-9821 based on careful use of -device and disabling default devices. 
I think the main issues some of the platform devices that aren't present 
in this machine (like the rtc) that aren't qdev-ified yet.  I think 
that's probably an easier path to take though.

BTW, this patch won't link on it's own because it relies on 
pc98_init_i8259 which this patch doesn't introduce.

Regards,

Anthony Liguori