From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSF8K-0002lZ-CH
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:32:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSF8E-0002cZ-Gr
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:31:58 -0500
Received: from [199.232.76.173] (port=60548 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSF8D-0002c6-Oo
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:31:53 -0500
Received: from mx20.gnu.org ([199.232.41.8]:35688)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1NSF8C-0004uM-1T
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:31:52 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NS5hK-0000fh-Ew
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 04:27:30 -0500
Message-ID: <4B4305F7.2040707@redhat.com>
Date: Tue, 05 Jan 2010 10:27:19 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1262626457-26671-1-git-send-email-amit.shah@redhat.com>
	<1262626457-26671-2-git-send-email-amit.shah@redhat.com>
	<1262626457-26671-3-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1262626457-26671-3-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/8] virtio-console: qdev conversion,
	new virtio-serial-bus
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, agraf@suse.de

   Hi,

> +/* Guest wants to notify us of some event */
> +static void handle_control_message(VirtIOSerial *vser, void *buf)
> +{

> +    cpkt->event = le16_to_cpu(cpkt->event);
> +    cpkt->value = le16_to_cpu(cpkt->value);

Does this modify guest memory?

> +        DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console, 1),

virtser_bus_dev_print() prints this.  Properties are printed by "info 
qtree" anyway, so you can drop that from virtser_bus_dev_print ...

cheers,
   Gerd