From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSF7Q-0001R5-06 for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:31:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSF7L-0001Ix-8L for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:31:03 -0500 Received: from [199.232.76.173] (port=60492 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSF7L-0001Ii-2t for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:30:59 -0500 Received: from mx20.gnu.org ([199.232.41.8]:35628) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSF7K-0004Ld-Q4 for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:30:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NS6Mv-00080P-8z for qemu-devel@nongnu.org; Tue, 05 Jan 2010 05:10:29 -0500 Message-ID: <4B430FFE.8030003@redhat.com> Date: Tue, 05 Jan 2010 11:10:06 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V4 05/18] support NEC PC-9821 keyboard References: <200912221740.AA00208@YOUR-BD18D6DD63.m1.interq.or.jp> In-Reply-To: <200912221740.AA00208@YOUR-BD18D6DD63.m1.interq.or.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "TAKEDA, toshiya" Cc: qemu-devel > +void pc98_kbd_init(void) > +{ > + ISADevice *dev; > + > + dev = isa_create("pc98-kbd"); > + qdev_init_nofail(&dev->qdev); > +} There is no need for such a wrapper. You can use isa_create_simple("pc98-kbd"); instead. Likewise for other devices (mouse, ...). cheers, Gerd