From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSF79-00012i-JX
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:30:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSF74-0000vD-Ny
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:30:46 -0500
Received: from [199.232.76.173] (port=60471 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSF74-0000uj-4V
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:30:42 -0500
Received: from mx20.gnu.org ([199.232.41.8]:35628)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1NSF73-0004Ld-So
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:30:41 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NS6XE-0000UJ-FN
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 05:21:08 -0500
Message-ID: <4B43127F.4090305@redhat.com>
Date: Tue, 05 Jan 2010 11:20:47 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH V4 11/18] fdc: support NEC PC-9821 interface
References: <200912221741.AA00214@YOUR-BD18D6DD63.m1.interq.or.jp>
In-Reply-To: <200912221741.AA00214@YOUR-BD18D6DD63.m1.interq.or.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "TAKEDA, toshiya" <t-takeda@m1.interq.or.jp>
Cc: qemu-devel <qemu-devel@nongnu.org>


> +fdctrl_t *pc98_fdctrl_init (DriveInfo **fds)
> +{
> +    ISADevice *dev;
> +    fdctrl_t *fdctrl;
> +    int i;
> +
> +    dev = isa_create("pc98-fdc");
> +    qdev_prop_set_drive(&dev->qdev, "driveA", fds[0]);
> +    qdev_prop_set_drive(&dev->qdev, "driveB", fds[1]);
> +    if (qdev_init(&dev->qdev)<  0)
> +        return NULL;
> +    fdctrl =&(DO_UPCAST(fdctrl_isabus_t, busdev, dev)->state);

This code ....

> +    fdctrl->if_mode = PC98_MODE_FDDEXC | PC98_MODE_PORTEXC;
> +    fdctrl->dor |= FD_DOR_DMAEN;
> +
> +    for (i = 0; i<  MAX_FD; i++) {
> +        fdrive_t *drv =&fdctrl->drives[i];
> +        if (drv->dinfo) {
> +            fdctrl_media_changed(drv);
> +        }
> +    }
> +    fdctrl->media_timer = qemu_new_timer(vm_clock,
> +                                         pc98_fdctrl_media_timer, fdctrl);
> +    qemu_mod_timer(fdctrl->media_timer,
> +                   qemu_get_clock(vm_clock) + get_ticks_per_sec() / 10);

... should be moved to ...

> +static int pc98_fdc_init1(ISADevice *dev)

... this function.

cheers,
   Gerd