From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSEsl-0005pk-2c
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSEsg-0005lN-BQ
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:54 -0500
Received: from [199.232.76.173] (port=53535 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSEsf-0005lB-UW
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:49 -0500
Received: from mx20.gnu.org ([199.232.41.8]:34932)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1NSEsb-0006ls-EE
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:45 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NSCq9-0001iw-Cp
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 12:05:05 -0500
Message-ID: <4B43711B.8090606@redhat.com>
Date: Tue, 05 Jan 2010 18:04:27 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new
	virtio-serial-bus
References: <1262626457-26671-1-git-send-email-amit.shah@redhat.com>	<1262626457-26671-2-git-send-email-amit.shah@redhat.com>
	<1262626457-26671-3-git-send-email-amit.shah@redhat.com>
	<4B436BFF.6090302@codemonkey.ws>
In-Reply-To: <4B436BFF.6090302@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Amit Shah <amit.shah@redhat.com>, armbru@redhat.com, qemu-devel@nongnu.org, agraf@suse.de

   Hi,

>> - .driver = "virtio-console-pci",
>> + .driver = "virtio-serial-pci",
>
> I don't think we can eliminate the virtio-console-pci device name. If
> someone used -writeconfig and -virtconsole in 0.12, this change would
> break their written config files.

It wouldn't.  virtio-console-pci was never fully converted to qdev 
because of the multichannel work in flight.  Thus you can't create a 
functional device using '-device virtio-console-pci,<properties>' 
because the driver lacks a chardev property.

>> CharDriverState *qdev_init_chardev(DeviceState *dev)
>> {
>> static int next_serial;
>> - static int next_virtconsole;
>> +
>> /* FIXME: This is a nasty hack that needs to go away. */
>
> Minor nit, this comment is no longer needed.

The whole function is a nasty hack which needs to go away.  The 
RightWay[tm] is to use a chardev property instead of this function.

So the comment is still correct.  Maybe some rewording is helpful though 
to make this more clear as the comment got a big bunch of review 
comments already ;)

cheers,
   Gerd