From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSEsb-0005hu-4y for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSEsW-0005ce-1f for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:44 -0500 Received: from [199.232.76.173] (port=53515 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSEsV-0005cR-Lz for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:39 -0500 Received: from mx20.gnu.org ([199.232.41.8]:34896) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSEsR-0006KX-Dh for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:15:35 -0500 Received: from qw-out-1920.google.com ([74.125.92.150]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NSCtW-0002N2-K6 for qemu-devel@nongnu.org; Tue, 05 Jan 2010 12:08:34 -0500 Received: by qw-out-1920.google.com with SMTP id 5so2696298qwc.4 for ; Tue, 05 Jan 2010 09:08:33 -0800 (PST) Message-ID: <4B43720E.7050607@codemonkey.ws> Date: Tue, 05 Jan 2010 11:08:30 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus References: <1262626457-26671-1-git-send-email-amit.shah@redhat.com> <1262626457-26671-2-git-send-email-amit.shah@redhat.com> <1262626457-26671-3-git-send-email-amit.shah@redhat.com> <4B436BFF.6090302@codemonkey.ws> <4B43711B.8090606@redhat.com> In-Reply-To: <4B43711B.8090606@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Amit Shah , armbru@redhat.com, qemu-devel@nongnu.org, agraf@suse.de On 01/05/2010 11:04 AM, Gerd Hoffmann wrote: > Hi, > >>> - .driver = "virtio-console-pci", >>> + .driver = "virtio-serial-pci", >> >> I don't think we can eliminate the virtio-console-pci device name. If >> someone used -writeconfig and -virtconsole in 0.12, this change would >> break their written config files. > > It wouldn't. virtio-console-pci was never fully converted to qdev > because of the multichannel work in flight. Thus you can't create a > functional device using '-device virtio-console-pci,' > because the driver lacks a chardev property. Ah, okay. >> Minor nit, this comment is no longer needed. > > The whole function is a nasty hack which needs to go away. The > RightWay[tm] is to use a chardev property instead of this function. > > So the comment is still correct. Maybe some rewording is helpful > though to make this more clear as the comment got a big bunch of > review comments already ;) Okay, then a small rewording with that point would be helpful. It wasn't clear to me that the function should become a property. > cheers, > Gerd