From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSEqF-0004X6-Ra
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:13:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSEqB-0004UK-28
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:13:19 -0500
Received: from [199.232.76.173] (port=54876 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSEqA-0004UE-RR
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:13:14 -0500
Received: from mx20.gnu.org ([199.232.41.8]:34740)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <anthony@codemonkey.ws>)
	id 1NSEq9-0004O2-OA
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:13:13 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NSDA8-0003oC-U8
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 12:25:45 -0500
Received: by yxe26 with SMTP id 26so15803698yxe.4
	for <qemu-devel@nongnu.org>; Tue, 05 Jan 2010 09:25:43 -0800 (PST)
Message-ID: <4B43760D.60202@codemonkey.ws>
Date: Tue, 05 Jan 2010 11:25:33 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new
	virtio-serial-bus
References: <1262626457-26671-1-git-send-email-amit.shah@redhat.com>
	<1262626457-26671-2-git-send-email-amit.shah@redhat.com>
	<1262626457-26671-3-git-send-email-amit.shah@redhat.com>
	<4B436BFF.6090302@codemonkey.ws>
	<20100105171603.GI19805@amit-x200.redhat.com>
In-Reply-To: <20100105171603.GI19805@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: agraf@suse.de, qemu-devel@nongnu.org, armbru@redhat.com, kraxel@redhat.com

On 01/05/2010 11:16 AM, Amit Shah wrote:
>>> +static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
>>> +{
>>> +    VirtIOSerialDevice *dev = DO_UPCAST(VirtIOSerialDevice, qdev, qdev);
>>> +    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev,&dev->qdev);
>>> +
>>> +    monitor_printf(mon, "%*s dev-prop-int: id: %u\n",
>>> +                   indent, "", port->id);
>>> +    monitor_printf(mon, "%*s dev-prop-int: is_console: %d\n",
>>> +                   indent, "", port->is_console);
>>> +}
>>>
>>>        
>> This will break the build since it's not referenced anywhere.
>>      
> Again, as mentioned in the other thread, it gets used here:
>
> static struct BusInfo virtser_bus_info = {
>      .name      = "virtio-serial-bus",
>      .size      = sizeof(VirtIOSerialBus),
>      .print_dev = virtser_bus_dev_print,
> };
>
> (I've compile- and run- tested these patches.)
>    

Okay.

> 		Amit
>