From: Stefan Weil <weil@mail.berlios.de>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH V12 24/27] pm_smbus: remove #ifdef DEBUG.
Date: Wed, 06 Jan 2010 12:42:28 +0100 [thread overview]
Message-ID: <4B447724.6070708@mail.berlios.de> (raw)
In-Reply-To: <1262745591-28697-25-git-send-email-yamahata@valinux.co.jp>
Isaku Yamahata schrieb:
> remove #ifdef DEBUG by using macro.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/pm_smbus.c | 21 ++++++++++++---------
> 1 files changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/hw/pm_smbus.c b/hw/pm_smbus.c
> index 6ef6b9e..9929d72 100644
> --- a/hw/pm_smbus.c
> +++ b/hw/pm_smbus.c
> @@ -37,6 +37,15 @@
> #define SMBHSTDAT1 0x06
> #define SMBBLKDAT 0x07
>
> +//#define DEBUG
> +
> +#ifdef DEBUG
> +# define SMBUS_DPRINTF(format, ...) printf(format, ## __VA_ARGS__)
Debug output should go to stderr. So this would be even better:
+# define SMBUS_DPRINTF(format, ...) fprintf(stderr, format, ## __VA_ARGS__)
Regards,
Stefan Weil
next prev parent reply other threads:[~2010-01-06 11:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 2:39 [Qemu-devel] [PATCH V12 00/27] split out piix specific part from pc emulator and some clean ups Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 01/27] acpi: split out piix4 smbus routines from acpi.c into pm_smbus.c Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 02/27] acpi: split out apm register emulation from acpi.c Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 03/27] acpi: add acpi constants from linux header files and use them Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 04/27] acpi: split acpi.c into the common part and the piix4 part Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 05/27] acpi_piix4: remove unused variable in get_pmsts() Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 06/27] pc: initialize ioapic before use Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 07/27] pc, i440fx: Make smm enable/disable function i440fx independent Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 08/27] pc: make an unnecessary global variable, pit, local Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 09/27] pc: remove a global variable, floppy_controller Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 10/27] pc: remove global variable rtc_state by using qemu_irq Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 11/27] pc: introduce a function to allocate cpu irq Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 12/27] pc: make pc_init1() not refer ferr_irq directly Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 13/27] pc: split out cpu initialization from pc_init1() into pc_cpus_init() Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 14/27] pc: split out memory allocation from pc_init1() into pc_memory_init() Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 15/27] pc: split out vga initialization from pc_init1() into pc_vga_init() Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 16/27] pc: split out basic device init from pc_init1() into pc_basic_device_init() Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 17/27] pc: split out pci device init from pc_init1() into pc_pci_device_init() Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 18/27] pc: split out piix specific part from pc.c into pc_piix.c Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 19/27] pc: move rtc declarations from pc.h into a dedicated header file Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 20/27] rtc: make rtc_xxx accept/return ISADevice instead of RTCState Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 21/27] acpi_piix4: qdevfy Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 22/27] pci hotplug: add argument to pci hot plug callback Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 23/27] pci hotadd, acpi_piix4: remove global variables Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 24/27] pm_smbus: remove #ifdef DEBUG Isaku Yamahata
2010-01-06 11:42 ` Stefan Weil [this message]
2010-01-06 23:51 ` Isaku Yamahata
2010-01-07 0:05 ` Igor Kovalenko
2010-01-17 16:09 ` [Qemu-devel] [RFC] Don't send local debug output to stdout (was: pm_smbus: remove #ifdef DEBUG) Stefan Weil
2010-02-24 2:28 ` Paul Brook
2010-02-24 18:29 ` [Qemu-devel] [RFC] Don't send local debug output to stdout Stefan Weil
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 25/27] acpi_piix4: remove #ifdef DEBUG Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 26/27] apm: " Isaku Yamahata
2010-01-06 2:39 ` [Qemu-devel] [PATCH V12 27/27] mc146818rtc: remove #ifdef DEBUG_CMOS Isaku Yamahata
2010-01-12 5:07 ` [Qemu-devel] [PATCH V12 00/27] split out piix specific part from pc emulator and some clean ups Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B447724.6070708@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=aurelien@aurel32.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).