From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSebn-000601-ED
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:44:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSebi-0005zl-Ks
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:44:06 -0500
Received: from [199.232.76.173] (port=50064 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSebi-0005zi-EI
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:44:02 -0500
Received: from mail-yw0-f176.google.com ([209.85.211.176]:46047)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NSebi-0004AV-06
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 17:44:02 -0500
Received: by ywh6 with SMTP id 6so17911472ywh.4
	for <qemu-devel@nongnu.org>; Wed, 06 Jan 2010 14:44:00 -0800 (PST)
Message-ID: <4B45122D.1020403@codemonkey.ws>
Date: Wed, 06 Jan 2010 16:43:57 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Qemu's internal TFTP server breaks lock-step-iness
	of TFTP
References: <1262815902.18404.341.camel@localhost>
In-Reply-To: <1262815902.18404.341.camel@localhost>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Milan Plzik <milan.plzik@gmail.com>
Cc: qemu-devel@nongnu.org

On 01/06/2010 04:11 PM, Milan Plzik wrote:
>    Hello,
>
>    according to RFC 1350 and RFC 2347, TFTP server should answer RRQ by
> either OACK or DATA packet. Qemu's internal TFTP server answers RRQ with
> additional options by sending both OACK and DATA packet, thus breaking
> the "lock-step" feature of the protocol, and also confuses client.
>
>    Proposed solution would be to, in case of OACK packet, wait for ACK
> from client and just then start sending data. Attached patch implements
> this.
>
>    I would like to thank to mbc and th1 (who is the rightful author of
> the patch) from #gpxe for their time, effort and patience with me :)
>    

Thanks for the patch, I assume this fixes -boot n when using -bootp and 
-tftp.  Can you add an appropriate Signed-off-by and resubmit?

Regards,

Anthony Liguori

> 	Milan Plzik
>