From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSvcC-0008Sc-Dp
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:53:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSvc7-0008OY-DD
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:53:39 -0500
Received: from [199.232.76.173] (port=60349 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSvc7-0008OI-77
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:53:35 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:60269)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NSvc6-00023i-QI
	for qemu-devel@nongnu.org; Thu, 07 Jan 2010 11:53:34 -0500
Received: by yxe26 with SMTP id 26so17833677yxe.4
	for <qemu-devel@nongnu.org>; Thu, 07 Jan 2010 08:53:32 -0800 (PST)
Message-ID: <4B46118A.9050101@codemonkey.ws>
Date: Thu, 07 Jan 2010 10:53:30 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf
References: <20100107124449.GY4905@redhat.com> <4B46072C.80909@codemonkey.ws>
	<20100107161503.GE4905@redhat.com>
In-Reply-To: <20100107161503.GE4905@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On 01/07/2010 10:15 AM, Gleb Natapov wrote:
>> KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always
>> been present in kvm_para.h.  Since we include kvm_para.h
>> unconditionally, there's no way we wouldn't have
>> KVM_CPUID_SIGNATURE.
>>
>>      
> It is there in qemu-kvm and we suppose to bring knowledge from there :)
>    

Hopefully just the good bits.

> But I can drop it if you like.
>    

I don't want to deviate unnecessarily from qemu-kvm so we can approach 
this in one of two ways.  We can remove the guard in qemu-kvm and Avi 
can send me a pull request with this feature.  I can also just pull in 
the patch as-is and we can fix this in both places later.  I'm happy 
either way.

Regards,

Anthony Liguori

> --
> 			Gleb.
>