qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>, Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver
Date: Thu, 07 Jan 2010 10:56:19 -0600	[thread overview]
Message-ID: <4B461233.2020808@codemonkey.ws> (raw)
In-Reply-To: <4B460E55.9090800@redhat.com>

On 01/07/2010 10:39 AM, Avi Kivity wrote:
> On 01/07/2010 06:27 PM, Adam Litke wrote:
>>
>>> I think 'info-balloon' should be synchronous and without side-effects.
>>> ie return the current stats that QEMU has. We could then add a separate
>>> 'refresh-balloon' command + async event notification when that 
>>> completes.
>>> The tool that is requiring the stats could thus refresh as often as it
>>> likes.
>> This would work well for the QMP case, but what about for a traditional
>> monitor?  We could include a sequence number or timestamp in the memory
>> stats results so the user could tell that they were updated.  This
>> doesn't seem very user friendly though
>
> A user would have an easier time logging into the guest and using its 
> native tools.

Yeah, without objections, I like having info-balloon attempt to refresh 
stats, timeout after 10s, and return the last reported stats.  I think 
it also satisfies danpb's criteria of not wasting cpu cycles polling.

Regards,

Anthony Liguori

  reply	other threads:[~2010-01-07 16:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 17:08 [Qemu-devel] [RFD] virtio: Add memory statistics reporting to the balloon driver Adam Litke
2010-01-07 15:12 ` [Qemu-devel] " Anthony Liguori
2010-01-07 15:18   ` Avi Kivity
2010-01-07 15:22     ` Anthony Liguori
2010-01-07 15:39       ` Adam Litke
2010-01-08  1:33       ` Jamie Lokier
2010-01-07 15:49   ` Daniel P. Berrange
2010-01-07 16:27     ` Adam Litke
2010-01-07 16:39       ` Avi Kivity
2010-01-07 16:56         ` Anthony Liguori [this message]
2010-01-07 17:58           ` Luiz Capitulino
2010-01-07 18:30             ` Luiz Capitulino
2010-01-08 16:31               ` Anthony Liguori
2010-01-08 16:51                 ` Luiz Capitulino
2010-01-08 17:01               ` Adam Litke
2010-01-08 17:25                 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B461233.2020808@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=agl@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).