From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSyZi-0006m3-5r for qemu-devel@nongnu.org; Thu, 07 Jan 2010 15:03:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSyZd-0006ey-KG for qemu-devel@nongnu.org; Thu, 07 Jan 2010 15:03:17 -0500 Received: from [199.232.76.173] (port=60322 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSyZd-0006em-2S for qemu-devel@nongnu.org; Thu, 07 Jan 2010 15:03:13 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:57841) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSyZc-0007mK-GT for qemu-devel@nongnu.org; Thu, 07 Jan 2010 15:03:12 -0500 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e9.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o07JtVbI024821 for ; Thu, 7 Jan 2010 14:55:31 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o07K38qa051448 for ; Thu, 7 Jan 2010 15:03:08 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o07K38E2021392 for ; Thu, 7 Jan 2010 18:03:08 -0200 Message-ID: <4B463DFC.5040505@linux.vnet.ibm.com> Date: Thu, 07 Jan 2010 14:03:08 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] write option roms in pc-bios/ References: <4B337318.6080901@redhat.com> <1261664861-15493-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1261664861-15493-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Juan Quintela , qemu-devel@nongnu.org, Avi Kivity On 12/24/2009 08:27 AM, Paolo Bonzini wrote: >>> The gdt address calculation in linuxboot.bin is broken in two ways: first >>> it loads %cs into %eax, but that instruction leaves the high bits of %eax >>> undefined and we did not clear them. Secondly, we completely ignore the >>> incorrect %eax, and use the undefined %ebx instead. >>> >>> With these issues fixed, linuxboot works again. >>> >> Wow, I wonder how it worked for me... >> > Got it. The option roms are built in pc-bios/optionrom, but QEMU loads > the ones in pc-bios. So actually I was always testing Alexander's code > even though I had done a "make -B" to feel safer. :-( > > Signed-off-by: Paolo Bonzini > This will wreak havoc on the tree since these are built by default and they are replacing files in revision control. Regards, Anthony Liguori