From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NT1fA-00089Y-Do for qemu-devel@nongnu.org; Thu, 07 Jan 2010 18:21:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NT1f5-000869-Dm for qemu-devel@nongnu.org; Thu, 07 Jan 2010 18:21:07 -0500 Received: from [199.232.76.173] (port=57202 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NT1f5-000863-8l for qemu-devel@nongnu.org; Thu, 07 Jan 2010 18:21:03 -0500 Received: from mx01.lb01.inode.at ([62.99.145.1]:55204 helo=mx.inode.at) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NT1f4-0004PH-QE for qemu-devel@nongnu.org; Thu, 07 Jan 2010 18:21:03 -0500 Received: from [85.127.19.14] (port=9688 helo=leo.subsole.org) by smartmx-01.inode.at with esmtp (Exim 4.69) (envelope-from ) id 1NT1ex-0006qE-U6 for qemu-devel@nongnu.org; Fri, 08 Jan 2010 00:20:55 +0100 Message-ID: <4B466C56.5020701@libera.cc> Date: Fri, 08 Jan 2010 00:20:54 +0100 From: Emmanuel Kasper MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Use of LONG_LONG_MAX breaks build on OSX ? List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hello Qemu does not build on my platform ( OSX / 10.5 / PowerPC ) because of the use of LONG_LONG_MAX in raw-posix.c Replacing LONG_LONG_MAX with LLONG_MAX fixes the build and is more standard IMHO ( LONG_LONG_MAX is GNU libc, LLONG_MAX is C99 standard ) The following patch makes this trivial switch. --- block-raw-posix.c.before 2010-01-07 22:40:37.000000000 +0100 +++ block-raw-posix.c 2010-01-07 22:41:43.000000000 +0100 @@ -782,7 +782,7 @@ if (size == 0) #endif #ifdef CONFIG_COCOA - size = LONG_LONG_MAX; + size = LLONG_MAX; #else size = lseek(fd, 0LL, SEEK_END); #endif