From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NTHn7-0005Wi-FL
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:34:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NTHn3-0005VS-Uw
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:34:25 -0500
Received: from [199.232.76.173] (port=50089 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NTHn3-0005VP-Ni
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:34:21 -0500
Received: from mail-gx0-f223.google.com ([209.85.217.223]:42057)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NTHn3-0007P8-BV
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:34:21 -0500
Received: by gxk23 with SMTP id 23so22846714gxk.2
	for <qemu-devel@nongnu.org>; Fri, 08 Jan 2010 08:34:20 -0800 (PST)
Message-ID: <4B475E89.1010406@codemonkey.ws>
Date: Fri, 08 Jan 2010 10:34:17 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [STABLE 0.12] QMP: Drop wrong assert()
References: <20091222010906.4a42ab1d@doriath>
In-Reply-To: <20091222010906.4a42ab1d@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: nathan@parenthephobia.org.uk, aliguori@us.ibm.com, qemu-devel@nongnu.org

On 12/21/2009 09:09 PM, Luiz Capitulino wrote:
> Some commands return a QList of QDicts, which is valid,
> but will trig the assert().
>
> Just drop it.
>
> Reported-by: Nathan Baum<nathan@parenthephobia.org.uk>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   monitor.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index c0dc48e..3af1d5c 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -283,7 +283,6 @@ static void monitor_protocol_emitter(Monitor *mon, QObject *data)
>       if (!monitor_has_error(mon)) {
>           /* success response */
>           if (data) {
> -            assert(qobject_type(data) == QTYPE_QDICT);
>               qobject_incref(data);
>               qdict_put_obj(qmp, "return", data);
>           } else {
>