From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NTI2p-0005Kt-7V
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:50:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NTI2k-0005HF-AM
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:50:38 -0500
Received: from [199.232.76.173] (port=34278 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NTI2k-0005HC-32
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:50:34 -0500
Received: from mail-gx0-f223.google.com ([209.85.217.223]:44943)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NTI2j-0006sI-O3
	for qemu-devel@nongnu.org; Fri, 08 Jan 2010 11:50:33 -0500
Received: by gxk23 with SMTP id 23so22862775gxk.2
	for <qemu-devel@nongnu.org>; Fri, 08 Jan 2010 08:50:32 -0800 (PST)
Message-ID: <4B476255.50000@codemonkey.ws>
Date: Fri, 08 Jan 2010 10:50:29 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fix chardev_init for win32
References: <a38b25541001041745hf825a20j3697f46d4bc5f184@mail.gmail.com>
In-Reply-To: <a38b25541001041745hf825a20j3697f46d4bc5f184@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 01/04/2010 07:45 PM, TeLeMan wrote:
> Before calling chardev_init_func(), socket_init() should be called on win32.
>    

Needs a Signed-off-by

Regards,

Anthony Liguori

> ---
>   vl.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 0f59142..3b39cad 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -5768,6 +5768,10 @@ int main(int argc, char **argv, char **envp)
>       if (default_vga)
>           vga_interface_type = VGA_CIRRUS;
>
> +#ifdef _WIN32
> +    socket_init();
> +#endif
> +
>       if (qemu_opts_foreach(&qemu_chardev_opts, chardev_init_func, NULL, 1) != 0)
>           exit(1);
>
> @@ -5873,10 +5877,6 @@ int main(int argc, char **argv, char **envp)
>           init_icount_adjust();
>       }
>
> -#ifdef _WIN32
> -    socket_init();
> -#endif
> -
>       if (net_init_clients()<  0) {
>           exit(1);
>       }
>