qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Huang Ying <ying.huang@intel.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [BUGFIX] MCE: Fix bug of IA32_MCG_STATUS after system reset
Date: Mon, 11 Jan 2010 10:00:55 -0600	[thread overview]
Message-ID: <4B4B4B37.9090102@codemonkey.ws> (raw)
In-Reply-To: <1262680344.31401.226.camel@yhuang-dev.sh.intel.com>

On 01/05/2010 02:32 AM, Huang Ying wrote:
> Now, if we inject a fatal MCE into guest OS, for example Linux, Linux
> will go panic and then reboot. But if we inject another MCE now,
> system will reset directly instead of go panic firstly, because
> MCG_STATUS.MCIP is set to 1 and not cleared after reboot. This is does
> not follow the behavior in real hardware.
>
> This patch fixes this via set env->mcg_status to 0 during system reset.
>
> Signed-off-by: Huang Ying<ying.huang@intel.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   target-i386/helper.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -617,6 +617,8 @@ void cpu_reset(CPUX86State *env)
>       env->dr[7] = DR7_FIXED_1;
>       cpu_breakpoint_remove_all(env, BP_CPU);
>       cpu_watchpoint_remove_all(env, BP_CPU);
> +
> +    env->mcg_status = 0;
>   }
>
>   void cpu_x86_close(CPUX86State *env)
>
>
>
>
>
>    

      reply	other threads:[~2010-01-11 16:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05  8:32 [Qemu-devel] [BUGFIX] MCE: Fix bug of IA32_MCG_STATUS after system reset Huang Ying
2010-01-11 16:00 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4B4B37.9090102@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).