From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUMhw-0004Ol-Ov
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 11:01:32 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUMhs-0004Ls-Do
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 11:01:32 -0500
Received: from [199.232.76.173] (port=56660 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUMhr-0004LY-Sx
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 11:01:27 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:56810)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NUMhq-0002oc-PT
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 11:01:26 -0500
Received: by mail-yx0-f188.google.com with SMTP id 26so20730971yxe.4
	for <qemu-devel@nongnu.org>; Mon, 11 Jan 2010 08:01:26 -0800 (PST)
Message-ID: <4B4B4B54.2030706@codemonkey.ws>
Date: Mon, 11 Jan 2010 10:01:24 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix CPU topology initialization
References: <416bd3c048a9b777180f2e2735e620f8b7206840.1262708768.git.jdenemar@redhat.com>
In-Reply-To: <416bd3c048a9b777180f2e2735e620f8b7206840.1262708768.git.jdenemar@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jiri Denemark <jdenemar@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/05/2010 10:26 AM, Jiri Denemark wrote:
> Late initialization of CPU topology in CPUState prevents KVM guests to
> actually see the topology.
>
> Signed-off-by: Jiri Denemark<jdenemar@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   vl.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e881e45..a03d7a6 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3484,10 +3484,10 @@ void qemu_init_vcpu(void *_env)
>   {
>       CPUState *env = _env;
>
> -    if (kvm_enabled())
> -        kvm_init_vcpu(env);
>       env->nr_cores = smp_cores;
>       env->nr_threads = smp_threads;
> +    if (kvm_enabled())
> +        kvm_init_vcpu(env);
>       return;
>   }
>
> @@ -3813,12 +3813,12 @@ void qemu_init_vcpu(void *_env)
>   {
>       CPUState *env = _env;
>
> +    env->nr_cores = smp_cores;
> +    env->nr_threads = smp_threads;
>       if (kvm_enabled())
>           kvm_start_vcpu(env);
>       else
>           tcg_init_vcpu(env);
> -    env->nr_cores = smp_cores;
> -    env->nr_threads = smp_threads;
>   }
>
>   void qemu_notify_event(void)
>