From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUPmk-0007HG-LB
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:18:42 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUPmf-0007F1-Vh
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:18:42 -0500
Received: from [199.232.76.173] (port=56298 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUPmf-0007Ep-JW
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:18:37 -0500
Received: from mail-qy0-f189.google.com ([209.85.221.189]:35128)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NUPmf-000128-6h
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:18:37 -0500
Received: by qyk27 with SMTP id 27so9567683qyk.20
	for <qemu-devel@nongnu.org>; Mon, 11 Jan 2010 11:18:35 -0800 (PST)
Message-ID: <4B4B7988.5090803@codemonkey.ws>
Date: Mon, 11 Jan 2010 13:18:32 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
References: <20100107124449.GY4905@redhat.com>
	<20100107162427.GF4905@redhat.com>
In-Reply-To: <20100107162427.GF4905@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

On 01/07/2010 10:24 AM, Gleb Natapov wrote:
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 4084503..6a841de 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -17,6 +17,7 @@
>   #include<sys/mman.h>
>
>   #include<linux/kvm.h>
> +#include<linux/kvm_para.h>

This breaks the build on a default F12 install because while kvm.h is 
present, kvm_para.h is not.  This is a hard one to fix.

We can default the kvm search path to /lib/modules/$(uname -r)/build, we 
can fix the glibc headers and live with it, or we can pull in the kvm 
headers into qemu.

Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?

Regards,

Anthony Liguori