From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUQ7n-0000dG-H5 for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:40:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUQ7i-0000ZQ-Ld for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:40:27 -0500 Received: from [199.232.76.173] (port=50227 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUQ7h-0000ZF-LW for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:40:21 -0500 Received: from qw-out-1920.google.com ([74.125.92.145]:57829) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUQ7h-0000QC-8J for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:40:21 -0500 Received: by qw-out-1920.google.com with SMTP id 5so3768324qwc.4 for ; Mon, 11 Jan 2010 11:40:20 -0800 (PST) Message-ID: <4B4B7EA2.2030501@codemonkey.ws> Date: Mon, 11 Jan 2010 13:40:18 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] use pkg-config for sdl when cross compiling References: <1262875338-4104-1-git-send-email-pbonzini@redhat.com> <1262875338-4104-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1262875338-4104-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 01/07/2010 08:42 AM, Paolo Bonzini wrote: > Together with the previous patch this enables using the prefixed > pkg-config, thus picking up the correct flags for SDL. Since > pkg-config has an awful lot of dependencies, I still use sdl-config > when not cross-compiling since some people may only have the latter. > Wouldn't it make more sense to try to use pkg-config always and if it's not available, fall back on sdl-config? That means we don't have a separate code path for cross compiling which means it's less likely to break. Regards, Anthony Liguori