From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUQEg-0003nG-K5 for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:47:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUQEb-0003kG-9s for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:47:33 -0500 Received: from [199.232.76.173] (port=38609 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUQEb-0003kD-3G for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:47:29 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:60222) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NUQEa-0002Lh-Ky for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:47:28 -0500 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e33.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o0BJiEhs007412 for ; Mon, 11 Jan 2010 12:44:14 -0700 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o0BJlBCe056324 for ; Mon, 11 Jan 2010 12:47:15 -0700 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o0BJl7ec031375 for ; Mon, 11 Jan 2010 12:47:07 -0700 Message-ID: <4B4B803A.2060507@linux.vnet.ibm.com> Date: Mon, 11 Jan 2010 13:47:06 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] virtio-pci: thinko fix References: <20100111155739.GA8588@redhat.com> In-Reply-To: <20100111155739.GA8588@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, yvugenfi@redhat.com, qemu-devel@nongnu.org On 01/11/2010 09:57 AM, Michael S. Tsirkin wrote: > Since patch ed757e140c0ada220f213036e4497315d24ca8bct, virtio will > sometimes clear all status registers on bus master disable, which loses > information such as VIRTIO_CONFIG_S_FAILED bit. This is a result of > a patch being misapplied: code uses ! instead of ~ for bit > operations as in Yan's original patch. This obviously does not make > sense. > Actually, the original patch used '!'. It didn't carry a Signed-off-by and when it was reposted with a SoB, this was changed to '~'. There was no indication though that the contents of the patch was different. Moral of the story is, when you make a change to the patch, add a (v2) and state in the commit message what change was made. Thanks for catching this. Regards, Anthony Liguori