From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUQOk-0001Iw-9x for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:57:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUQOf-0001ID-Oc for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:57:57 -0500 Received: from [199.232.76.173] (port=60228 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUQOf-0001I8-Ic for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:57:53 -0500 Received: from mail-qy0-f189.google.com ([209.85.221.189]:36833) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUQOf-0005Pq-7e for qemu-devel@nongnu.org; Mon, 11 Jan 2010 14:57:53 -0500 Received: by qyk27 with SMTP id 27so9587099qyk.20 for ; Mon, 11 Jan 2010 11:57:52 -0800 (PST) Message-ID: <4B4B82BE.2060003@codemonkey.ws> Date: Mon, 11 Jan 2010 13:57:50 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max References: <1262849506-27132-1-git-send-email-amit.shah@redhat.com> <1262849506-27132-2-git-send-email-amit.shah@redhat.com> In-Reply-To: <1262849506-27132-2-git-send-email-amit.shah@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org On 01/07/2010 01:31 AM, Amit Shah wrote: > VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in > hw/virtio.h. > > Also, bump up the value of the maximum allowed virtqueues to 64. This is > in preparation to allow multiple ports per virtio-console device. > > Signed-off-by: Amit Shah > These will need rebasing against master. It gets pretty ugly because of the rename. Wait for me to do a review (today or tomorrow) before hand though. I'll explicitly reply and Ack/Nack. Regards, Anthony Liguori