From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com
Subject: Re: [Qemu-devel] [PATCH 4/5] tcg-sparc: Implement division properly.
Date: Mon, 11 Jan 2010 12:11:25 -0800 [thread overview]
Message-ID: <4B4B85ED.5080001@twiddle.net> (raw)
In-Reply-To: <89dafaffa4df925094d2d43acc985cb040d6161c.1263237726.git.rth@twiddle.net>
On 01/11/2010 11:09 AM, Richard Henderson wrote:
> + /* Load Y with the sign/zero extension of RS1 to 64-bits. */
> + if (uns) {
> + tcg_out_sety(s, TCG_REG_G0);
> + } else {
> + tcg_out_arith(s, TCG_REG_I5, rs1, 31, SHIFT_SRA);
Bah. tcg_out_arithi.
Programming by code inspection only sucks.
r~
next prev parent reply other threads:[~2010-01-11 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 19:22 [Qemu-devel] [PATCH 0/5] tcg-sparc improvements Richard Henderson
2010-01-11 17:51 ` [Qemu-devel] [PATCH 1/5] tcg-sparc: Add tcg_out_arithc Richard Henderson
2010-01-11 17:57 ` [Qemu-devel] [PATCH 2/5] tcg-sparc: Implement add2, sub2, mulu2 Richard Henderson
2010-01-11 19:00 ` [Qemu-devel] [PATCH 3/5] tcg-sparc: Do not remove %o[012] from 'r' constraint Richard Henderson
2010-01-11 19:09 ` [Qemu-devel] [PATCH 4/5] tcg-sparc: Implement division properly Richard Henderson
2010-01-11 20:11 ` Richard Henderson [this message]
2010-01-11 19:21 ` [Qemu-devel] [PATCH 5/5] tcg-sparc: Implement ext32[su]_i64 Richard Henderson
2010-01-11 20:41 ` [Qemu-devel] [PATCH 0/5] tcg-sparc improvements Palle Lyckegaard
2010-01-12 20:02 ` [Qemu-devel] " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4B85ED.5080001@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).