From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NURuE-0006yX-Ht
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:34:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NURu9-0006wf-T6
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:34:34 -0500
Received: from [199.232.76.173] (port=40933 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NURu9-0006wc-Pl
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:34:29 -0500
Received: from qw-out-1920.google.com ([74.125.92.147]:12162)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NURu9-0001Hb-Cq
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:34:29 -0500
Received: by qw-out-1920.google.com with SMTP id 5so3790252qwc.4
	for <qemu-devel@nongnu.org>; Mon, 11 Jan 2010 13:34:27 -0800 (PST)
Message-ID: <4B4B9960.8060105@codemonkey.ws>
Date: Mon, 11 Jan 2010 15:34:24 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC] New naming rules for GPXE romfiles
References: <1261134074-11795-1-git-send-email-kraxel@redhat.com>	<1261134074-11795-3-git-send-email-kraxel@redhat.com>
	<4B4B95B8.5090609@mail.berlios.de>
In-Reply-To: <4B4B95B8.5090609@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org

On 01/11/2010 03:18 PM, Stefan Weil wrote:
> The current names of GPXE romfiles are something like
> pxe-e1000.bin, pxe-ne2k_pci.bin, pxe-rtl8139.bin.
>
> This was adequate when these names were computed
> by a simple rule using the device name.
>
> Today, an ethernet device can be associated to any
> romfile name.
>
> Etherboot's Rom-o-Matic (which creates qemu's romfiles)
> creates names like gpxe-0.9.9-80861209.rom.
>
> I don't think it would be good to use etherboot's names
> because they contain the gpxe version (0.9.9) which
> might change.
>
> But a modified name without the gpxe version like
> gpxe-80861209.rom would have some advantages:
>
> * gpxe* is better than pxe* because the files contain
>    a gPXE boot ROM - not a proprietary PXE ROM.
>
> * The romfiles are ROM files, not undefined binaries,
>    so *.rom looks better than *.bin.
>
> * For drivers like eepro100.c which implement several devices,
>    a naming rule based on PCI device and vendor id (80861209)
>    is better than a rule based on device names:
>    devices with same ids can share the same romfile.
>
> * Transforming an etherboot romfile name to a qemu romfile name
>    is simple when all you have to do is to remove the version.
>    This would also simplify pc-bios/README.
>
> The proposed new names should be used for new romfiles.
> Optionally, the existing romfiles could be renamed.
>
> Please tell me what you think of these suggestions.
>    

I don't feel strongly either way.

Regards,

Anthony Liguori