From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NURw7-0007Sa-8U
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:36:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NURw1-0007Qd-Ie
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:36:30 -0500
Received: from [199.232.76.173] (port=40987 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NURw1-0007QT-7i
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:36:25 -0500
Received: from qw-out-1920.google.com ([74.125.92.147]:50741)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NURw0-0001pA-LI
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 16:36:24 -0500
Received: by qw-out-1920.google.com with SMTP id 5so3790662qwc.4
	for <qemu-devel@nongnu.org>; Mon, 11 Jan 2010 13:36:24 -0800 (PST)
Message-ID: <4B4B99D3.9090705@codemonkey.ws>
Date: Mon, 11 Jan 2010 15:36:19 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
References: <20100107124449.GY4905@redhat.com>
	<20100107162427.GF4905@redhat.com>
	<4B4B7988.5090803@codemonkey.ws> <4B4B8CD4.8090505@web.de>
In-Reply-To: <4B4B8CD4.8090505@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>, kvm-devel <kvm@vger.kernel.org>

On 01/11/2010 02:40 PM, Jan Kiszka wrote:
> Anthony Liguori wrote:
>    
>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>      
>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>> index 4084503..6a841de 100644
>>> --- a/target-i386/kvm.c
>>> +++ b/target-i386/kvm.c
>>> @@ -17,6 +17,7 @@
>>>    #include<sys/mman.h>
>>>
>>>    #include<linux/kvm.h>
>>> +#include<linux/kvm_para.h>
>>>        
>> This breaks the build on a default F12 install because while kvm.h is
>> present, kvm_para.h is not.  This is a hard one to fix.
>>
>> We can default the kvm search path to /lib/modules/$(uname -r)/build, we
>> can fix the glibc headers and live with it, or we can pull in the kvm
>> headers into qemu.
>>
>> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>>      
> kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
> release (missed the need for it so far). I'm planning to write a qemu
> patch to ask pkg-config for kvm-kmod headers.
>    

That would be nice.

I assume a change has to be made in the kernel too so that the libc 
headers are updated.  IOW, I assume make headers_install doesn't 
currently install kvm_para.h

> If we can live with considering the cpuid leaf a feature that depends on
> a recent kvm-kmod version and is disabled otherwise, we are done. If
> not, tricks like the above are required.
>    

It's less than ideal, but I can live with it.

Regards,

Anthony Liguori

> Jan
>
>