From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUcJ8-0006f1-QB
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:40:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUcJ0-0006dQ-VI
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:40:56 -0500
Received: from [199.232.76.173] (port=43163 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUcJ0-0006d6-1v
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:40:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:7352)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NUcIz-00070h-HJ
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:40:49 -0500
Message-ID: <4B4C358C.2090507@redhat.com>
Date: Tue, 12 Jan 2010 10:40:44 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
References: <20100107124449.GY4905@redhat.com>
	<20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws>
	<20100112072302.GP7549@redhat.com>
In-Reply-To: <20100112072302.GP7549@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>

On 01/12/2010 09:23 AM, Gleb Natapov wrote:
> On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote:
>    
>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>      
>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>> index 4084503..6a841de 100644
>>> --- a/target-i386/kvm.c
>>> +++ b/target-i386/kvm.c
>>> @@ -17,6 +17,7 @@
>>>   #include<sys/mman.h>
>>>
>>>   #include<linux/kvm.h>
>>> +#include<linux/kvm_para.h>
>>>        
>> This breaks the build on a default F12 install because while kvm.h
>> is present, kvm_para.h is not.  This is a hard one to fix.
>>
>>      
> Avi how qemu-kvm compiles there? Or it doesn't?
>
>    

include/linux/Kbuild has:

ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \
                   $(srctree)/include/asm-$(SRCARCH)/kvm.h),)
unifdef-y += kvm.h
endif
ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
                   $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
unifdef-y += kvm_para.h
endif

So it should be installed.  Unfortunately this is starting 2.6.32, so we 
need to backport the patch (da18acffc3) to the F12 kernel.

qemu-kvm doesn't depend on installed headers.

-- 
error compiling committee.c: too many arguments to function