From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>,
qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
Date: Tue, 12 Jan 2010 10:42:54 +0200 [thread overview]
Message-ID: <4B4C360E.1080508@redhat.com> (raw)
In-Reply-To: <4B4B7988.5090803@codemonkey.ws>
On 01/11/2010 09:18 PM, Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index 4084503..6a841de 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -17,6 +17,7 @@
>> #include<sys/mman.h>
>>
>> #include<linux/kvm.h>
>> +#include<linux/kvm_para.h>
>
> This breaks the build on a default F12 install because while kvm.h is
> present, kvm_para.h is not. This is a hard one to fix.
>
> We can default the kvm search path to /lib/modules/$(uname -r)/build,
> we can fix the glibc headers and live with it, or we can pull in the
> kvm headers into qemu.
>
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>
Two options:
- make kvm detection depend on kvm_para.h being includable, fix all
relevant distro kernels to supply it, and live with the breakage
- add a new CONFIG_KVM_PARA, detect it at configure time, and only
include it if present
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-01-12 8:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 12:44 [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf Gleb Natapov
2010-01-07 16:09 ` Anthony Liguori
2010-01-07 16:15 ` Gleb Natapov
2010-01-07 16:53 ` Anthony Liguori
2010-01-07 16:56 ` Avi Kivity
2010-01-07 17:08 ` Gleb Natapov
2010-01-07 18:02 ` Anthony Liguori
2010-01-07 18:10 ` Gleb Natapov
2010-01-07 16:59 ` Gleb Natapov
2010-01-07 16:24 ` [Qemu-devel] [PATCHv2] " Gleb Natapov
2010-01-11 19:18 ` Anthony Liguori
2010-01-11 19:33 ` [Qemu-devel] Registering key events android (qemu based) emulator Anwar Ghani
2010-01-11 20:40 ` [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Jan Kiszka
2010-01-11 21:36 ` Anthony Liguori
2010-01-11 23:22 ` Jan Kiszka
2010-01-12 7:23 ` Gleb Natapov
2010-01-12 8:40 ` Avi Kivity
2010-01-12 8:42 ` Avi Kivity [this message]
2010-01-13 13:25 ` [Qemu-devel] [PATCHv3] " Gleb Natapov
2010-01-13 16:05 ` Anthony Liguori
2010-01-13 16:14 ` Gleb Natapov
2010-01-13 16:23 ` Gleb Natapov
2010-01-13 16:57 ` Anthony Liguori
2010-01-13 23:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4C360E.1080508@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).