From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUcLC-0007CE-AY
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:43:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUcL6-0007Ai-Fc
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:43:05 -0500
Received: from [199.232.76.173] (port=54411 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUcL4-0007AR-NX
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:42:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:64730)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NUcL4-0007S1-86
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:42:58 -0500
Message-ID: <4B4C360E.1080508@redhat.com>
Date: Tue, 12 Jan 2010 10:42:54 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
References: <20100107124449.GY4905@redhat.com>
	<20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws>
In-Reply-To: <4B4B7988.5090803@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>, kvm-devel <kvm@vger.kernel.org>

On 01/11/2010 09:18 PM, Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index 4084503..6a841de 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -17,6 +17,7 @@
>>   #include<sys/mman.h>
>>
>>   #include<linux/kvm.h>
>> +#include<linux/kvm_para.h>
>
> This breaks the build on a default F12 install because while kvm.h is 
> present, kvm_para.h is not.  This is a hard one to fix.
>
> We can default the kvm search path to /lib/modules/$(uname -r)/build, 
> we can fix the glibc headers and live with it, or we can pull in the 
> kvm headers into qemu.
>
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>

Two options:

- make kvm detection depend on kvm_para.h being includable, fix all 
relevant distro kernels to supply it, and live with the breakage
- add a new CONFIG_KVM_PARA, detect it at configure time, and only 
include it if present

-- 
error compiling committee.c: too many arguments to function