From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUcP0-0008O2-8V for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:47:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUcOv-0008Mt-TB for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:47:01 -0500 Received: from [199.232.76.173] (port=54467 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUcOv-0008Mi-JE for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:46:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53423) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUcOv-0008GJ-4C for qemu-devel@nongnu.org; Tue, 12 Jan 2010 03:46:57 -0500 Message-ID: <4B4C36FC.3070503@redhat.com> Date: Tue, 12 Jan 2010 09:46:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] use pkg-config for sdl when cross compiling References: <1262875338-4104-1-git-send-email-pbonzini@redhat.com> <1262875338-4104-3-git-send-email-pbonzini@redhat.com> <4B4B7EA2.2030501@codemonkey.ws> In-Reply-To: <4B4B7EA2.2030501@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 01/11/2010 08:40 PM, Anthony Liguori wrote: > > Wouldn't it make more sense to try to use pkg-config always and if it's > not available, fall back on sdl-config? > > That means we don't have a separate code path for cross compiling which > means it's less likely to break. I certainly can make that, I wanted to avoid changing the most frequently used path to avoid breaking stuff more than I already did. :-( It's not frequently-changing code, so it's not so likely to break. Paolo