From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUdvt-0002Ln-Lv for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:25:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUdvo-0002JZ-Dg for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:25:04 -0500 Received: from [199.232.76.173] (port=42049 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUdvn-0002JU-WB for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:25:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34472) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUdvn-0000SH-HE for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:24:59 -0500 Message-ID: <4B4C4DBF.8020907@redhat.com> Date: Tue, 12 Jan 2010 11:23:59 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC] New naming rules for GPXE romfiles References: <1261134074-11795-1-git-send-email-kraxel@redhat.com> <1261134074-11795-3-git-send-email-kraxel@redhat.com> <4B4B95B8.5090609@mail.berlios.de> In-Reply-To: <4B4B95B8.5090609@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org Am 11.01.2010 22:18, schrieb Stefan Weil: > The current names of GPXE romfiles are something like > pxe-e1000.bin, pxe-ne2k_pci.bin, pxe-rtl8139.bin. > > This was adequate when these names were computed > by a simple rule using the device name. > > Today, an ethernet device can be associated to any > romfile name. > > Etherboot's Rom-o-Matic (which creates qemu's romfiles) > creates names like gpxe-0.9.9-80861209.rom. > > I don't think it would be good to use etherboot's names > because they contain the gpxe version (0.9.9) which > might change. > > But a modified name without the gpxe version like > gpxe-80861209.rom would have some advantages: > > * gpxe* is better than pxe* because the files contain > a gPXE boot ROM - not a proprietary PXE ROM. > > * The romfiles are ROM files, not undefined binaries, > so *.rom looks better than *.bin. > > * For drivers like eepro100.c which implement several devices, > a naming rule based on PCI device and vendor id (80861209) > is better than a rule based on device names: > devices with same ids can share the same romfile. I dislike this part of your suggestion. Everyone knows what a pcnet is, but I guess most people don't know its PCI device/vendor ID. So it would add files that most people can't associate with anything specific. Maybe you could name your files gpxe-eepro100-vendor_dev.rom and just leave vendor_dev out for devices with just one ID? I'm fine with the other suggestions, though. Kevin