From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUhqE-0007z4-Pi for qemu-devel@nongnu.org; Tue, 12 Jan 2010 09:35:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUhqA-0007yS-5q for qemu-devel@nongnu.org; Tue, 12 Jan 2010 09:35:30 -0500 Received: from [199.232.76.173] (port=52536 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUhqA-0007yP-02 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 09:35:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34434) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUhq9-0006F0-1T for qemu-devel@nongnu.org; Tue, 12 Jan 2010 09:35:25 -0500 Message-ID: <4B4C88A5.4040506@redhat.com> Date: Tue, 12 Jan 2010 09:35:17 -0500 From: Cole Robinson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] raw-posix: Detect IDE floppy via ioctl References: <1263234619-14522-2-git-send-email-crobinso@redhat.com> <20100112101602.GA10900@lst.de> In-Reply-To: <20100112101602.GA10900@lst.de> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org On 01/12/2010 05:16 AM, Christoph Hellwig wrote: > On Mon, Jan 11, 2010 at 01:30:19PM -0500, Cole Robinson wrote: >> Current IDE floppy detection is hardcoded based on source file name. >> Make this smarter by attempting a floppy specific ioctl. > > IDE floppys show up as /dev/hd?, these are old legacy floppies. > Ah, didn't realize there was a difference. > Otherwise looks good except that I think the ioctl should have a higher > match priority than the name match. Same applies to the CDROM version > of the patch. Will do. Thanks, Cole