From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUiHl-0002ee-7j for qemu-devel@nongnu.org; Tue, 12 Jan 2010 10:03:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUiHg-0002bd-7J for qemu-devel@nongnu.org; Tue, 12 Jan 2010 10:03:56 -0500 Received: from [199.232.76.173] (port=57381 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUiHf-0002bQ-NX for qemu-devel@nongnu.org; Tue, 12 Jan 2010 10:03:51 -0500 Received: from mail-yw0-f176.google.com ([209.85.211.176]:49907) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUiHf-0006LX-9W for qemu-devel@nongnu.org; Tue, 12 Jan 2010 10:03:51 -0500 Received: by ywh6 with SMTP id 6so22510001ywh.4 for ; Tue, 12 Jan 2010 07:03:50 -0800 (PST) Message-ID: <4B4C8F54.9040603@codemonkey.ws> Date: Tue, 12 Jan 2010 09:03:48 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] use pkg-config for sdl when cross compiling References: <1262875338-4104-1-git-send-email-pbonzini@redhat.com> <1262875338-4104-3-git-send-email-pbonzini@redhat.com> <4B4B7EA2.2030501@codemonkey.ws> <4B4C36FC.3070503@redhat.com> In-Reply-To: <4B4C36FC.3070503@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 01/12/2010 02:46 AM, Paolo Bonzini wrote: > On 01/11/2010 08:40 PM, Anthony Liguori wrote: >> >> Wouldn't it make more sense to try to use pkg-config always and if it's >> not available, fall back on sdl-config? >> >> That means we don't have a separate code path for cross compiling which >> means it's less likely to break. > > I certainly can make that, I wanted to avoid changing the most > frequently used path to avoid breaking stuff more than I already did. :-( > > It's not frequently-changing code, so it's not so likely to break. I'd prefer that we have a single code path instead of different paths for cross compiling. Regards, Anthony Liguori > Paolo