From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCHv7 3/3] virtio: add features as qdev properties
Date: Tue, 12 Jan 2010 18:05:54 +0100 [thread overview]
Message-ID: <4B4CABF2.5050204@redhat.com> (raw)
In-Reply-To: <20100110115253.GD27013@redhat.com>
Hi,
> +#define DEFINE_VIRTIO_NET_FEATURES(_state, _field) \
> + DEFINE_VIRTIO_COMMON_FEATURES(_state, _field), \
> + DEFINE_PROP_BIT("csum", _state, _field, VIRTIO_NET_F_CSUM, true), \
> + DEFINE_PROP_BIT("guest_csum", _state, _field, VIRTIO_NET_F_GUEST_CSUM, true), \
> + DEFINE_PROP_BIT("mac", _state, _field, VIRTIO_NET_F_MAC, true), \
Didn't noticed in review, sorry. This isn't going to work as all
network cards already have a 'mac' property to set the mac address. Try
to create a virtio nic with a non-default mac address and watch qemu fail.
cheers,
Gerd
next prev parent reply other threads:[~2010-01-12 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1263124239.git.mst@redhat.com>
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 1/3] qdev: add bit property type Michael S. Tsirkin
2010-01-11 19:50 ` Anthony Liguori
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 2/3] virtio: rename features -> guest_features Michael S. Tsirkin
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties Michael S. Tsirkin
2010-01-12 17:05 ` Gerd Hoffmann [this message]
2010-01-12 18:50 ` [Qemu-devel] " Michael S. Tsirkin
2010-01-12 18:09 ` [Qemu-devel] " Christoph Hellwig
2010-01-12 18:52 ` Michael S. Tsirkin
2010-01-12 19:50 ` Michael S. Tsirkin
2010-01-12 22:06 ` Christoph Hellwig
2010-01-13 10:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4CABF2.5050204@redhat.com \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).