From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUkLb-0001ek-BN for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:16:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUkLX-0001bm-Ru for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:16:03 -0500 Received: from [199.232.76.173] (port=57462 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUkLX-0001bY-Hu for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:15:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49378) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUkLW-0003iu-Vh for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:15:59 -0500 Message-ID: <4B4CAE12.9020704@redhat.com> Date: Tue, 12 Jan 2010 18:14:58 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit References: <20100111175137.GA7571@lst.de> <4B4C9D70.2090506@redhat.com> <20100112170905.GA31233@lst.de> In-Reply-To: <20100112170905.GA31233@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Am 12.01.2010 18:09, schrieb Christoph Hellwig: > On Tue, Jan 12, 2010 at 05:04:00PM +0100, Kevin Wolf wrote: >> To keep the behaviour as previously you'd need to set at least bs->drv >> in the unlink_and_fail case, too. I have no clue why it's important to >> set it to NULL when bs isn't going to be used anyway (probably it is, >> but I don't know where), but Fabrice committed this in 6b21b973 as a >> fix. Unfortunately, the commit message looks like most of Fabrice's >> commit messages, so it's of no use for me... > > The unlink_and_fail label can only be reached from places where we > haven't set bs->drv yet, so it should be fine. Sorry, I confused drv and bs->drv. Looks alright then. Acked-by: Kevin Wolf