From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUkwX-000593-Cf for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:54:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUkwR-00054L-B8 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:54:12 -0500 Received: from [199.232.76.173] (port=50222 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUkwR-00053y-1B for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:54:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43826 helo=mx2.suse.de) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUkwQ-00071O-G7 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:54:06 -0500 Message-ID: <4B4CB738.3000708@suse.de> Date: Tue, 12 Jan 2010 18:54:00 +0100 From: Alexander Graf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 6/6] pci host: make pci_data_{write, read}() get PCIConfigAddress. References: <1263286378-10398-1-git-send-email-yamahata@valinux.co.jp> <1263286378-10398-7-git-send-email-yamahata@valinux.co.jp> In-Reply-To: <1263286378-10398-7-git-send-email-yamahata@valinux.co.jp> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: Blue Swirl , Paul Brook , qemu-devel@nongnu.org, Aurelien Jarno , mst@redhat.com Isaku Yamahata wrote: > Move out pci address decoding logic from pci_data_{write, read}() > by making pci_data_{write, read}() get PCIConfigAddress. > I think this is going in the wrong direction. You are keeping the device specific MMIO/PIO based config space access handlers and just move the address decoding into a separate function. The whole idea of my patch was to only use pci_host to handle the MMIOs and have a simple callback into a bus specific decoder. That way we could probably remove most of the functions you're patching in this patch. Or am I wrong here? Alex