From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUmWq-0004wQ-5h
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:35:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUmWl-0004qc-7z
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:35:47 -0500
Received: from [199.232.76.173] (port=57891 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUmWk-0004q9-Qk
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:35:43 -0500
Received: from mail-qy0-f194.google.com ([209.85.221.194]:39573)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NUmWk-0003ej-HL
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 14:35:42 -0500
Received: by qyk32 with SMTP id 32so2601016qyk.4
	for <qemu-devel@nongnu.org>; Tue, 12 Jan 2010 11:35:42 -0800 (PST)
Message-ID: <4B4CCF0C.8000407@codemonkey.ws>
Date: Tue, 12 Jan 2010 13:35:40 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20100112191659.GA3258@redhat.com>
In-Reply-To: <20100112191659.GA3258@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qdev: fix thinko leading to guest crashes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kraxel@redhat.com, qemu-devel@nongnu.org, hch@lst.de

On 01/12/2010 01:16 PM, Michael S. Tsirkin wrote:
> Without this fix, guest crashes with drive=virtio.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>
> Anthony, could you please apply this patch quickly?
> It's an obvious one and it fixes guest crashes.
> Also, sorry about missing this in my testing.
>
>   hw/qdev-properties.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9e123ae..277ff9e 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -20,7 +20,7 @@ static void bit_prop_set(DeviceState *dev, Property *props, bool val)
>       uint32_t *p = qdev_get_prop_ptr(dev, props);
>       uint32_t mask = qdev_get_prop_mask(props);
>       if (val)
> -        *p |= ~mask;
> +        *p |= mask;
>       else
>           *p&= ~mask;
>   }
>