* [Qemu-devel] [PATCH] qdev: fix thinko leading to guest crashes
@ 2010-01-12 19:16 Michael S. Tsirkin
2010-01-12 19:35 ` [Qemu-devel] " Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2010-01-12 19:16 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori, hch, kraxel
Without this fix, guest crashes with drive=virtio.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Anthony, could you please apply this patch quickly?
It's an obvious one and it fixes guest crashes.
Also, sorry about missing this in my testing.
hw/qdev-properties.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 9e123ae..277ff9e 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -20,7 +20,7 @@ static void bit_prop_set(DeviceState *dev, Property *props, bool val)
uint32_t *p = qdev_get_prop_ptr(dev, props);
uint32_t mask = qdev_get_prop_mask(props);
if (val)
- *p |= ~mask;
+ *p |= mask;
else
*p &= ~mask;
}
--
1.6.6.rc1.43.gf55cc
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] qdev: fix thinko leading to guest crashes
2010-01-12 19:16 [Qemu-devel] [PATCH] qdev: fix thinko leading to guest crashes Michael S. Tsirkin
@ 2010-01-12 19:35 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2010-01-12 19:35 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kraxel, qemu-devel, hch
On 01/12/2010 01:16 PM, Michael S. Tsirkin wrote:
> Without this fix, guest crashes with drive=virtio.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> Anthony, could you please apply this patch quickly?
> It's an obvious one and it fixes guest crashes.
> Also, sorry about missing this in my testing.
>
> hw/qdev-properties.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9e123ae..277ff9e 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -20,7 +20,7 @@ static void bit_prop_set(DeviceState *dev, Property *props, bool val)
> uint32_t *p = qdev_get_prop_ptr(dev, props);
> uint32_t mask = qdev_get_prop_mask(props);
> if (val)
> - *p |= ~mask;
> + *p |= mask;
> else
> *p&= ~mask;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-12 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-12 19:16 [Qemu-devel] [PATCH] qdev: fix thinko leading to guest crashes Michael S. Tsirkin
2010-01-12 19:35 ` [Qemu-devel] " Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).