From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NV1gF-0007fw-Sf
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 06:46:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NV1gB-0007fU-4Q
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 06:46:31 -0500
Received: from [199.232.76.173] (port=35344 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NV1gA-0007fR-VU
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 06:46:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41010)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1NV1gA-0007J2-IQ
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 06:46:26 -0500
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0DBkOou005034
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 13 Jan 2010 06:46:25 -0500
Message-ID: <4B4DB28E.9070601@redhat.com>
Date: Wed, 13 Jan 2010 12:46:22 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1263380087-31821-1-git-send-email-amit.shah@redhat.com>	<1263380087-31821-2-git-send-email-amit.shah@redhat.com>	<1263380087-31821-3-git-send-email-amit.shah@redhat.com>	<1263380087-31821-4-git-send-email-amit.shah@redhat.com>	<1263380087-31821-5-git-send-email-amit.shah@redhat.com>
	<1263380087-31821-6-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1263380087-31821-6-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/6] qcow2-refcount: remove dead assignment
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/13/2010 11:54 AM, Amit Shah wrote:
> clang-analyzer points out a redundant assignment.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
> ---
>   block/qcow2-refcount.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 54b19f8..3a2d44a 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -511,7 +511,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs,
>       l2_table = NULL;
>       l1_table = NULL;
>       l1_size2 = l1_size * sizeof(uint64_t);
> -    l1_allocated = 0;
>       if (l1_table_offset != s->l1_table_offset) {
>           if (l1_size2 != 0) {
>               l1_table = qemu_mallocz(align_offset(l1_size2, 512));

I'd remove the l1_allocated = 0 assignment in the else branch instead 
(the idea is, assign l1_allocated = 1 right after any qemu_malloc.

Paolo