From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NV27X-0008C4-AW for qemu-devel@nongnu.org; Wed, 13 Jan 2010 07:14:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NV27Q-0008BJ-UB for qemu-devel@nongnu.org; Wed, 13 Jan 2010 07:14:41 -0500 Received: from [199.232.76.173] (port=35866 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NV27Q-0008BF-H8 for qemu-devel@nongnu.org; Wed, 13 Jan 2010 07:14:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29571) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NV27Q-0005pu-1h for qemu-devel@nongnu.org; Wed, 13 Jan 2010 07:14:36 -0500 Message-ID: <4B4DB924.5000409@redhat.com> Date: Wed, 13 Jan 2010 13:14:28 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1262880810-16210-1-git-send-email-weil@mail.berlios.de> <20100111183757.GA13725@redhat.com> In-Reply-To: <20100111183757.GA13725@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] eepro100: Update ROM file support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: QEMU Developers On 01/11/10 19:37, Michael S. Tsirkin wrote: > On Thu, Jan 07, 2010 at 05:13:30PM +0100, Stefan Weil wrote: >> Use new way to associate ROM files to devices. Patch looks good to me. >> Maybe it is even possible to create a single >> pxe-i8255x.bin which supports all eepro100 devices >> (not supported with current etherboot). Would be nice indeed. Via .romfile we can easily handle any device -> rom filename mapping though, so if this doesn't work out it isn't a big issue too. >> >> Signed-off-by: Stefan Weil > > Gerd, could you ack this patch please? Acked-by: Gerd Hoffmann cheers, Gerd