From: Anthony Liguori <anthony@codemonkey.ws>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests
Date: Wed, 13 Jan 2010 12:31:06 -0600 [thread overview]
Message-ID: <4B4E116A.1040206@codemonkey.ws> (raw)
In-Reply-To: <m34omqnczi.fsf@blackfin.pond.sub.org>
On 01/13/2010 11:14 AM, Markus Armbruster wrote:
> Anthony Liguori<anthony@codemonkey.ws> writes:
>
>
>> On 01/12/2010 01:16 AM, Amit Shah wrote:
>>
>>> BTW I don't really want this too, I can get rid of it if everyone agrees
>>> we won't support clipboard writes> 4k over vnc or if there's a better
>>> idea.
>>>
>>>
>> Why bother trying to preserve message boundaries? I think that's the
>> fundamental question.
>>
> Yes. Either it's a datagram or a stream pipe. I always thought it
> would be a stream pipe, as the name "serial" suggests.
>
And if it's a datagram, then we should accept that there will be a fixed
max message size which is pretty common in all datagram protocols. That
fixed size should be no larger than what the transport supports so in
this case, it would be 4k.
If a guest wants to send larger messages, it must build a continuation
protocol on top of the datagram protocol.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-13 18:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 7:31 [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 3/8] virtio-serial-bus: Maintain guest and host port open/close state Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 4/8] virtio-serial-bus: Add a port 'name' property for port discovery in guests Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 6/8] virtio-serial-bus: Add ability to hot-unplug ports Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 7/8] virtio-serial: Add a 'virtserialport' device for generic serial port support Amit Shah
2010-01-07 7:31 ` [Qemu-devel] [PATCH 8/8] Move virtio-serial to Makefile.hw Amit Shah
2010-01-08 0:41 ` Andreas Färber
2010-01-08 5:01 ` Amit Shah
2010-01-08 1:12 ` [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests Jamie Lokier
2010-01-08 5:03 ` Amit Shah
2010-01-08 13:35 ` Jamie Lokier
2010-01-08 16:26 ` Anthony Liguori
2010-01-11 8:39 ` Amit Shah
2010-01-12 0:28 ` Anthony Liguori
2010-01-12 7:08 ` Amit Shah
2010-01-11 8:34 ` Amit Shah
2010-01-11 10:45 ` Jamie Lokier
2010-01-11 11:04 ` Amit Shah
2010-01-11 23:33 ` Jamie Lokier
2010-01-12 0:27 ` Anthony Liguori
2010-01-12 7:16 ` Amit Shah
2010-01-12 15:00 ` Anthony Liguori
2010-01-12 15:13 ` Amit Shah
2010-01-12 15:46 ` Anthony Liguori
2010-01-12 15:49 ` Amit Shah
2010-01-12 15:55 ` Anthony Liguori
2010-01-12 16:04 ` Amit Shah
2010-01-13 17:14 ` Markus Armbruster
2010-01-13 18:31 ` Anthony Liguori [this message]
2010-01-11 19:57 ` [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2010-01-14 13:17 [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 3/8] virtio-serial-bus: Maintain guest and host port open/close state Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 4/8] virtio-serial-bus: Add a port 'name' property for port discovery in guests Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests Amit Shah
2010-01-04 17:34 [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports Amit Shah
2010-01-04 17:34 ` [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Amit Shah
2010-01-04 17:34 ` [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus Amit Shah
2010-01-04 17:34 ` [Qemu-devel] [PATCH 3/8] virtio-serial-bus: Maintain guest and host port open/close state Amit Shah
2010-01-04 17:34 ` [Qemu-devel] [PATCH 4/8] virtio-serial-bus: Add a port 'name' property for port discovery in guests Amit Shah
2010-01-04 17:34 ` [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4E116A.1040206@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).