From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVCbT-0000tf-Qm for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:26:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVCbP-0000tL-Be for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:26:19 -0500 Received: from [199.232.76.173] (port=57776 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVCbP-0000tI-6m for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:26:15 -0500 Received: from mail-qy0-f194.google.com ([209.85.221.194]:53148) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NVCbO-00019Y-T2 for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:26:15 -0500 Received: by qyk32 with SMTP id 32so3454287qyk.4 for ; Wed, 13 Jan 2010 15:26:13 -0800 (PST) Message-ID: <4B4E5692.9010906@codemonkey.ws> Date: Wed, 13 Jan 2010 17:26:10 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Qemu's internal TFTP server breaks lock-step-iness of TFTP References: <1262867983.18404.659.camel@localhost> In-Reply-To: <1262867983.18404.659.camel@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Milan Plzik Cc: qemu-devel@nongnu.org On 01/07/2010 06:39 AM, Milan Plzik wrote: > According to RFC 1350 and RFC 2347, TFTP server should answer RRQ by > either OACK or DATA packet. Qemu's internal TFTP server answers RRQ with > additional options by sending both OACK and DATA packet, thus breaking > the "lock-step" feature of the protocol, and also confuses client. > > Proposed solution would be to, in case of OACK packet, wait for ACK > from client and just then start sending data. Attached patch implements > this. > > Signed-off-by: Thomas Horsten > Signed-off-by: Milan Plzik > > Applied. Thanks. Regards, Anthony Liguori