From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/4] use cross-prefix for pkgconfig
Date: Wed, 13 Jan 2010 17:27:07 -0600 [thread overview]
Message-ID: <4B4E56CB.8050708@codemonkey.ws> (raw)
In-Reply-To: <1263372776-23753-2-git-send-email-pbonzini@redhat.com>
On 01/13/2010 02:52 AM, Paolo Bonzini wrote:
> Since pkgconfig can give different output for different targets,
> it should be tried with the cross-compilation prefix first.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
Applied all. Thanks.
Regards,
Anthony Liguori
> ---
> configure | 19 ++++++++++++++-----
> 1 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 5c056f5..f3584db 100755
> --- a/configure
> +++ b/configure
> @@ -965,6 +965,15 @@ EOF
> fi
>
> ##########################################
> +# pkgconfig probe
> +
> +pkgconfig="${cross_prefix}pkg-config"
> +if ! test -x "$(which $pkgconfig 2>/dev/null)"; then
> + # likely not cross compiling, or hope for the best
> + pkgconfig=pkg-config
> +fi
> +
> +##########################################
> # Sparse probe
> if test "$sparse" != "no" ; then
> if test -x "$(which cgcc 2>/dev/null)"; then
> @@ -1047,8 +1056,8 @@ if test "$vnc_tls" != "no" ; then
> #include<gnutls/gnutls.h>
> int main(void) { gnutls_session_t s; gnutls_init(&s, GNUTLS_SERVER); return 0; }
> EOF
> - vnc_tls_cflags=`pkg-config --cflags gnutls 2> /dev/null`
> - vnc_tls_libs=`pkg-config --libs gnutls 2> /dev/null`
> + vnc_tls_cflags=`$pkgconfig --cflags gnutls 2> /dev/null`
> + vnc_tls_libs=`$pkgconfig --libs gnutls 2> /dev/null`
> if compile_prog "$vnc_tls_cflags" "$vnc_tls_libs" ; then
> vnc_tls=yes
> libs_softmmu="$vnc_tls_libs $libs_softmmu"
> @@ -1320,7 +1329,7 @@ if test "$check_utests" != "no" ; then
> #include<check.h>
> int main(void) { suite_create("qemu test"); return 0; }
> EOF
> - check_libs=`pkg-config --libs check`
> + check_libs=`$pkgconfig --libs check`
> if compile_prog "" $check_libs ; then
> check_utests=yes
> libs_tools="$check_libs $libs_tools"
> @@ -1339,8 +1348,8 @@ if test "$bluez" != "no" ; then
> #include<bluetooth/bluetooth.h>
> int main(void) { return bt_error(0); }
> EOF
> - bluez_cflags=`pkg-config --cflags bluez 2> /dev/null`
> - bluez_libs=`pkg-config --libs bluez 2> /dev/null`
> + bluez_cflags=`$pkgconfig --cflags bluez 2> /dev/null`
> + bluez_libs=`$pkgconfig --libs bluez 2> /dev/null`
> if compile_prog "$bluez_cflags" "$bluez_libs" ; then
> bluez=yes
> libs_softmmu="$bluez_libs $libs_softmmu"
>
next prev parent reply other threads:[~2010-01-13 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 8:52 [Qemu-devel] [PATCH v3 0/4] pkg-config related fixes for cross compilation Paolo Bonzini
2010-01-13 8:52 ` [Qemu-devel] [PATCH v3 1/4] use cross-prefix for pkgconfig Paolo Bonzini
2010-01-13 23:27 ` Anthony Liguori [this message]
2010-01-13 8:52 ` [Qemu-devel] [PATCH v3 2/4] fixes to the static compilation case for sdl Paolo Bonzini
2010-01-13 8:52 ` [Qemu-devel] [PATCH v3 3/4] use pkg-config for sdl whenever available Paolo Bonzini
2010-01-13 8:52 ` [Qemu-devel] [PATCH v3 4/4] use pkg-config for libcurl " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4E56CB.8050708@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).