From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NVCdX-0001Tk-AJ
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:28:27 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NVCdS-0001SA-Gw
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:28:26 -0500
Received: from [199.232.76.173] (port=46299 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NVCdS-0001S3-Bo
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:28:22 -0500
Received: from mail-qy0-f194.google.com ([209.85.221.194]:34668)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NVCdR-0001J3-SC
	for qemu-devel@nongnu.org; Wed, 13 Jan 2010 18:28:22 -0500
Received: by mail-qy0-f194.google.com with SMTP id 32so3454591qyk.4
	for <qemu-devel@nongnu.org>; Wed, 13 Jan 2010 15:28:21 -0800 (PST)
Message-ID: <4B4E5713.6020607@codemonkey.ws>
Date: Wed, 13 Jan 2010 17:28:19 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] osdep.c: Fix accept4 fallback
References: <1263396056-7816-1-git-send-email-kwolf@redhat.com>
In-Reply-To: <1263396056-7816-1-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/13/2010 09:20 AM, Kevin Wolf wrote:
> Commit 3a03bfa5 added a fallback in case the Linux kernel running qemu is older
> than the kernel of the build system. Unfortunately, v1 was committed instead of
> v2, so the code has a bug that was revealed in the review (checking for the
> wrong error code).
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   osdep.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/osdep.c b/osdep.c
> index e4836e7..1310684 100644
> --- a/osdep.c
> +++ b/osdep.c
> @@ -297,7 +297,7 @@ int qemu_accept(int s, struct sockaddr *addr, socklen_t *addrlen)
>
>   #ifdef CONFIG_ACCEPT4
>       ret = accept4(s, addr, addrlen, SOCK_CLOEXEC);
> -    if (ret != -1 || errno != EINVAL) {
> +    if (ret != -1 || errno != ENOSYS) {
>           return ret;
>       }
>   #endif
>