From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports
Date: Thu, 14 Jan 2010 08:34:42 -0600 [thread overview]
Message-ID: <4B4F2B82.9000800@codemonkey.ws> (raw)
In-Reply-To: <1263475063-15238-1-git-send-email-amit.shah@redhat.com>
On 01/14/2010 07:17 AM, Amit Shah wrote:
> Hello people,
>
> This iteration of the series removes the START and END flags (and
> hence the header associated with each buffer). That's the major change
> since the last submission.
>
I think the biggest issue remaining is the buffering.
I think this is a pretty fundamental issue to work out since it
determines the very nature of the transport (stream vs. datagram).
Because you have to put a max buffer size on the transport, I think
buffering is a really flawed approach provably equivalent to just
increasing the message size within the transport. In general, the later
is a better approach because then the guest is using it's memory vs.
using host memory.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-14 14:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 13:17 [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 3/8] virtio-serial-bus: Maintain guest and host port open/close state Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 4/8] virtio-serial-bus: Add a port 'name' property for port discovery in guests Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 6/8] virtio-serial-bus: Add ability to hot-unplug ports Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 7/8] virtio-serial: Add a 'virtserialport' device for generic serial port support Amit Shah
2010-01-14 13:17 ` [Qemu-devel] [PATCH 8/8] Move virtio-serial to Makefile.objs Amit Shah
2010-01-14 14:34 ` Anthony Liguori [this message]
2010-01-14 15:34 ` [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports Amit Shah
2010-01-19 14:33 ` Anthony Liguori
2010-01-19 17:59 ` Jamie Lokier
2010-01-19 18:59 ` Amit Shah
-- strict thread matches above, loose matches on Subject: below --
2010-01-19 19:06 Amit Shah
2010-01-07 7:31 Amit Shah
2010-01-04 17:34 Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4F2B82.9000800@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).