From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: parameter
Date: Mon, 18 Jan 2010 10:24:21 +0100 [thread overview]
Message-ID: <4B5428C5.4050309@redhat.com> (raw)
In-Reply-To: <4B50CAEA.6070900@web.de>
On 01/15/10 21:07, Jan Kiszka wrote:
> The missing '@' broke 'udp::<port>@:<port>' parsing.
> if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)< 2) {
> host[0] = 0;
> - if (sscanf(p, ":%32[^,]%n", port,&pos)< 1) {
> + if (sscanf(p, ":%32[^@,]%n", port,&pos)< 1) {
Indeed.
> fprintf(stderr, "udp #1\n");
While you are at it, can you also zap this debug leftover?
thanks,
Gerd
next prev parent reply other threads:[~2010-01-18 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 20:07 [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: parameter Jan Kiszka
2010-01-18 9:24 ` Gerd Hoffmann [this message]
2010-01-18 10:21 ` Jan Kiszka
2010-01-18 10:47 ` Gerd Hoffmann
2010-01-18 11:15 ` [Qemu-devel] [PATCH][STABLE] Drop debug printfs from qemu_chr_parse_compat Jan Kiszka
2010-01-18 11:25 ` [Qemu-devel] " Gerd Hoffmann
2010-02-28 13:19 ` [Qemu-devel] " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5428C5.4050309@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).