From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NWnql-0008KH-HI
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 04:24:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NWnqg-0008Ib-7O
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 04:24:42 -0500
Received: from [199.232.76.173] (port=49026 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NWnqg-0008IY-1M
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 04:24:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41399)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NWnqf-0001oP-JE
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 04:24:37 -0500
Message-ID: <4B5428C5.4050309@redhat.com>
Date: Mon, 18 Jan 2010 10:24:21 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp:
	parameter
References: <4B50CAEA.6070900@web.de>
In-Reply-To: <4B50CAEA.6070900@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 01/15/10 21:07, Jan Kiszka wrote:
> The missing '@' broke 'udp::<port>@:<port>' parsing.

>           if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)<  2) {
>               host[0] = 0;
> -            if (sscanf(p, ":%32[^,]%n", port,&pos)<  1) {
> +            if (sscanf(p, ":%32[^@,]%n", port,&pos)<  1) {

Indeed.

>                   fprintf(stderr, "udp #1\n");

While you are at it, can you also zap this debug leftover?

thanks,
   Gerd