From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWpZo-0007xH-VB for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWpZi-0007qa-5q for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:19 -0500 Received: from [199.232.76.173] (port=33522 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWpZh-0007qK-TZ for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:14 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:35738) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWpZg-0003h0-HH for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:15:13 -0500 Message-ID: <4B5442B5.5070409@web.de> Date: Mon, 18 Jan 2010 12:15:01 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4B50CAEA.6070900@web.de> <4B5428C5.4050309@redhat.com> <4B543618.9030602@web.de> <4B543C33.1070701@redhat.com> In-Reply-To: <4B543C33.1070701@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA9EBE82C665B4B4B2FD437C2" Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH][STABLE] Drop debug printfs from qemu_chr_parse_compat List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Anthony Liguori , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA9EBE82C665B4B4B2FD437C2 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Gerd Hoffmann wrote: > On 01/18/10 11:21, Jan Kiszka wrote: >> Gerd Hoffmann wrote: >>> On 01/15/10 21:07, Jan Kiszka wrote: >>>> The missing '@' broke 'udp::@:' parsing. >>> >>>> if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)< 2= ) { >>>> host[0] =3D 0; >>>> - if (sscanf(p, ":%32[^,]%n", port,&pos)< 1) { >>>> + if (sscanf(p, ":%32[^@,]%n", port,&pos)< 1) { >>> >>> Indeed. >>> >>>> fprintf(stderr, "udp #1\n"); >>> >>> While you are at it, can you also zap this debug leftover? >> >> Looks like there are three of them in qemu_chr_parse_compat - kill >> them all? >=20 > Yes. >=20 > thanks, > Gerd >=20 Signed-off-by: Jan Kiszka --- qemu-char.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a8a92f5..ef7823f 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2315,7 +2315,6 @@ QemuOpts *qemu_chr_parse_compat(const char *label, = const char *filename) if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port, &pos) < 2) { host[0] =3D 0; if (sscanf(p, ":%32[^@,]%n", port, &pos) < 1) { - fprintf(stderr, "udp #1\n"); goto fail; } } @@ -2326,7 +2325,6 @@ QemuOpts *qemu_chr_parse_compat(const char *label, = const char *filename) if (sscanf(p, "%64[^:]:%32[^,]%n", host, port, &pos) < 2) { host[0] =3D 0; if (sscanf(p, ":%32[^,]%n", port, &pos) < 1) { - fprintf(stderr, "udp #2\n"); goto fail; } } @@ -2354,7 +2352,6 @@ QemuOpts *qemu_chr_parse_compat(const char *label, = const char *filename) } =20 fail: - fprintf(stderr, "%s: fail on \"%s\"\n", __FUNCTION__, filename); qemu_opts_del(opts); return NULL; } --------------enigA9EBE82C665B4B4B2FD437C2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAktUQrkACgkQitSsb3rl5xQRvwCeJWhQqf+RFjtYXSrZd6+HAutG aesAoMsdpzs+WGPtHkX9YcOpExXrAJQU =Wmwj -----END PGP SIGNATURE----- --------------enigA9EBE82C665B4B4B2FD437C2--